Skip to content

Update hipdnn install tests for data_sdk and flatbuffers_sdk#4662

Merged
SamuelReeder merged 2 commits intomainfrom
users/sareeder/flatbuffers-sdk-install-test
Apr 20, 2026
Merged

Update hipdnn install tests for data_sdk and flatbuffers_sdk#4662
SamuelReeder merged 2 commits intomainfrom
users/sareeder/flatbuffers-sdk-install-test

Conversation

@SamuelReeder
Copy link
Copy Markdown
Contributor

Summary

  • Fix hipdnn_data_sdk install test to use hipdnn_data_sdk/utilities/Tensor.hpp instead of the moved graph_generated.h header
  • Add separate hipdnn_flatbuffers_sdk install test with hipdnn_flatbuffers_sdk/data_objects/graph_generated.h

Test plan

  • CI hipdnn install tests pass

🤖 Generated with Claude Code

Copy link
Copy Markdown
Contributor

@BrianHarrisonAMD BrianHarrisonAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamuelReeder SamuelReeder merged commit 497af57 into main Apr 20, 2026
314 of 365 checks passed
@SamuelReeder SamuelReeder deleted the users/sareeder/flatbuffers-sdk-install-test branch April 20, 2026 14:13
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Apr 20, 2026
dileepr1 pushed a commit that referenced this pull request Apr 20, 2026
## Summary
- Fix `hipdnn_data_sdk` install test to use
`hipdnn_data_sdk/utilities/Tensor.hpp` instead of the moved
`graph_generated.h` header
- Add separate `hipdnn_flatbuffers_sdk` install test with
`hipdnn_flatbuffers_sdk/data_objects/graph_generated.h`

## Test plan
- [ ] CI hipdnn install tests pass

🤖 Generated with [Claude Code](https://claude.com/claude-code)
chiranjeevipattigidi pushed a commit that referenced this pull request Apr 21, 2026
## Summary
- Fix `hipdnn_data_sdk` install test to use
`hipdnn_data_sdk/utilities/Tensor.hpp` instead of the moved
`graph_generated.h` header
- Add separate `hipdnn_flatbuffers_sdk` install test with
`hipdnn_flatbuffers_sdk/data_objects/graph_generated.h`

## Test plan
- [ ] CI hipdnn install tests pass

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants