Skip to content

Don't exclude strix halo in build #4661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
charest wants to merge 2 commits into from
Closed

Don't exclude strix halo in build #4661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df331b4
Don't exclude strix halo in build
charest Apr 17, 2026
fae47fc
Merge branch 'main' into users/cmarc/strix_halo_fix
charest Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions cmake/therock_amdgpu_targets.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,6 @@ therock_add_amdgpu_target(gfx1150 "AMD Strix Point iGPU" FAMILY igpu-all gfx115X
therock_add_amdgpu_target(gfx1151 "AMD Strix Halo iGPU" FAMILY igpu-all gfx115X-all gfx115X-igpu
EXCLUDE_TARGET_PROJECTS
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rccl # https://github.com/ROCm/TheRock/issues/150
rccl-tests
Comment on lines -239 to -240
Copy link
Copy Markdown
Member

@ScottTodd ScottTodd Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't support additional RCCL targets until #2130 is resolved (see the other exclusions in this file now). Each additional build target adds too much link time to the critical path for every CI/CD build.

On this PR, the comm-libs stage took 3h54m (https://github.com/ROCm/TheRock/actions/runs/24734903539/job/72365287361?pr=4661), compared to the baseline of ~1h30m (https://github.com/ROCm/TheRock/actions/runs/24795953473/job/72570414857). Some part of that can be attributed to cache misses, but in general RCCL's current architecture is not compatible with project requirements. That is being worked on with increasing priority now that RCCL builds are the bottleneck.

Copy link
Copy Markdown

@alex-breslow-amd alex-breslow-amd Apr 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you see if this resolves your issue? @ScottTodd #2130 (comment) @stellaraccident

Copy link
Copy Markdown
Member

@ScottTodd ScottTodd Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build times have improved substantially after pulling in ROCm/rocm-systems#4795 . We could attempt to enable gfx1151 (and other targets) in the RCCL build now.

Copy link
Copy Markdown
Member

@ScottTodd ScottTodd Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabled gfx1151 (and other targets) in #4935, closing this PR.

rocprofiler-compute # https://github.com/ROCm/TheRock/issues/2892
)
therock_add_amdgpu_target(gfx1152 "AMD Krackan 1 iGPU" FAMILY igpu-all gfx115X-all gfx115X-igpu
Expand Down
2 changes: 1 addition & 1 deletion debug-tools/rocgdb/source
Open in desktop
Submodule source updated 15 files
+0 −45 .github/workflows/pre-commit.yml
+4 −4 .github/workflows/therock-ci-linux.yml
+2 −5 .github/workflows/therock-ci.yml
+2 −2 .github/workflows/therock-test-packages.yml
+4 −0 binutils/readelf.c
+1 −5 gdb/dwarf2/frame.c
+3 −3 gdb/gdb-hip-test-mode.h
+3 −3 gdb/local-fileio-target.h
+4 −3 gdb/location_scope.h
+0 −54 gdb/testsuite/gdb.dwarf2/debug-frame-no-cfa.exp
+0 −101 gdb/testsuite/gdb.dwarf2/debug-frame.S
+0 −130 gdb/testsuite/gdb.dwarf2/debug-frame.exp
+1 −1 gdb/testsuite/gdb.rocm/generic-address.exp
+1 −0 gdb/testsuite/gdb.rocm/watch-gpu-global-from-host.exp
+1 −444 gdb/testsuite/lib/dwarf.exp
2 changes: 1 addition & 1 deletion rocm-libraries
Open in desktop
Submodule rocm-libraries updated 1354 files
2 changes: 1 addition & 1 deletion rocm-systems
Open in desktop
Submodule rocm-systems updated 1303 files
Loading