-
Notifications
You must be signed in to change notification settings - Fork 241
Add extended test support to multi-arch CI workflows #4649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lajagapp
wants to merge
7
commits into
main
Choose a base branch
from
users/lajagapp/extended-test-multi-arch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5e13f53
Add extended test support to multi-arch CI workflows
lajagapp 293abdf
Comment out test_artifacts.yml inputs not yet available on main
lajagapp 328e61e
Merge branch 'main' into users/lajagapp/extended-test-multi-arch
lajagapp 8c13ed1
Revert workaround for test_artifacts.yml inputs (#3986 merged)
lajagapp b33c394
Merge branch 'users/lajagapp/extended-test-multi-arch' of https://git…
lajagapp 9bae4c6
Merge branch 'main' into users/lajagapp/extended-test-multi-arch
lajagapp 28418df
Consolidate redundant extended-test unit tests
lajagapp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,9 @@ on: | |
| type: string | ||
| test_type: | ||
| type: string | ||
| run_extended_tests: | ||
| type: string | ||
| default: 'false' | ||
| release_type: | ||
| description: 'Release type: "" for CI, or "dev", "nightly", "prerelease".' | ||
| type: string | ||
|
|
@@ -110,15 +113,18 @@ jobs: | |
| matrix: | ||
| family_info: ${{ fromJSON(inputs.build_config).per_family_info }} | ||
| uses: ./.github/workflows/test_artifacts.yml | ||
| secrets: inherit | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's remove this, last i remember, the API no longer worsk |
||
| with: | ||
| # Use architecture-specific artifact group for fetching per-arch artifacts | ||
| artifact_group: ${{ matrix.family_info.amdgpu_family }} | ||
| amdgpu_families: ${{ matrix.family_info.amdgpu_family }} | ||
| amdgpu_targets: ${{ matrix.family_info.amdgpu_targets }} | ||
| test_runs_on: ${{ matrix.family_info.test-runs-on }} | ||
| benchmark_runs_on: ${{ matrix.family_info.benchmark-runs-on }} | ||
| test_type: ${{ inputs.test_type }} | ||
| test_labels: ${{ inputs.test_labels }} | ||
| sanity_check_only_for_family: ${{ matrix.family_info.sanity_check_only_for_family }} | ||
| run_extended_tests: ${{ inputs.run_extended_tests }} | ||
| release_type: ${{ inputs.release_type }} | ||
|
|
||
| build_python_packages: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -368,9 +368,7 @@ class TestRocmDecision(JobGroupDecision): | |
|
|
||
| test_type: str = "quick" | ||
| test_type_reason: str = "default" | ||
| # TODO: Consolidate test_type, test labels, and run_functional_tests | ||
| # (from the single-arch pipeline) into a per-platform test config object | ||
| # (e.g. linux_test_config JSON) instead of separate top-level outputs. | ||
|
Comment on lines
-371
to
-373
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add back comment, this work does not finish this |
||
| run_extended_tests: bool = False | ||
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
|
|
@@ -603,10 +601,14 @@ def decide_jobs( | |
| ci_inputs=ci_inputs, | ||
| git_context=git_context, | ||
| ) | ||
| run_extended_tests = ci_inputs.is_schedule or ( | ||
| ci_inputs.is_workflow_dispatch and _has_test_labels(ci_inputs) | ||
| ) | ||
| test_rocm = TestRocmDecision( | ||
| action=JobAction.RUN, | ||
| test_type=test_type, | ||
| test_type_reason=test_type_reason, | ||
| run_extended_tests=run_extended_tests, | ||
| ) | ||
|
|
||
| # Other jobs run unconditionally with no configuration. | ||
|
|
@@ -871,6 +873,7 @@ def _expand_build_config_for_platform( | |
| "amdgpu_family": platform_info["family"], | ||
| "amdgpu_targets": ",".join(platform_info["fetch-gfx-targets"]), | ||
| "test-runs-on": test_runs_on, | ||
| "benchmark-runs-on": platform_info.get("benchmark-runs-on", ""), | ||
| "sanity_check_only_for_family": platform_info.get( | ||
| "sanity_check_only_for_family", False | ||
| ), | ||
|
|
@@ -967,12 +970,16 @@ def write_outputs( | |
| linux = outputs.builds.linux | ||
| windows = outputs.builds.windows | ||
| test_type = outputs.jobs.test_rocm.test_type if outputs.is_ci_enabled else "" | ||
| run_extended_tests = ( | ||
| outputs.jobs.test_rocm.run_extended_tests if outputs.is_ci_enabled else False | ||
| ) | ||
| output_vars = { | ||
| # Workflow YAML references this as 'enable_build_jobs' | ||
| "enable_build_jobs": json.dumps(outputs.is_ci_enabled), | ||
| "linux_build_config": json.dumps(linux.to_dict()) if linux else "", | ||
| "windows_build_config": json.dumps(windows.to_dict()) if windows else "", | ||
| "test_type": test_type, | ||
| "run_extended_tests": json.dumps(run_extended_tests), | ||
| "linux_test_labels": outputs.linux_test_labels, | ||
| "windows_test_labels": outputs.windows_test_labels, | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove this