Skip to content

Issue #4506: fix CI concurrency grouping for PR and dispatch runs#4643

Open
rwilliamspbg-ops wants to merge 4 commits intoROCm:mainfrom
rwilliamspbg-ops:users/ryan/issue-4506-ci-concurrency
Open

Issue #4506: fix CI concurrency grouping for PR and dispatch runs#4643
rwilliamspbg-ops wants to merge 4 commits intoROCm:mainfrom
rwilliamspbg-ops:users/ryan/issue-4506-ci-concurrency

Conversation

@rwilliamspbg-ops
Copy link
Copy Markdown

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

@ScottTodd
Copy link
Copy Markdown
Member

What sort of testing have you done on this? Please fill out the PR template (or delete parts of it that don't apply)

@rwilliamspbg-ops
Copy link
Copy Markdown
Author

Motivation

Issue #4506 reported that the current concurrency key can cancel unrelated workflow_dispatch runs on main, and can also produce confusing behavior when PR events arrive as opened and labeled in quick succession.

Technical Details

  • Updated the concurrency.group expression in both CI workflows.
  • The new key uses github.head_ref for PRs so PR events coalesce to one run.
  • The fallback uses github.run_id for non-PR events so workflow_dispatch and other runs on main do not cancel each other unexpectedly.

Changed workflows:

  • .github/workflows/ci.yml
  • .github/workflows/multi_arch_ci.yml

Test Plan

  • Verified the modified workflow files with diagnostics in the workspace.

Test Result

  • No workflow diagnostics reported for the edited YAML files.

Submission Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

2 participants