Issue #4105: include s3_management tests in unit test discovery#4642
Issue #4105: include s3_management tests in unit test discovery#4642rwilliamspbg-ops wants to merge 6 commits into
Conversation
|
Duplicate of #4107 ? |
MotivationIssue #4105 reported that build_tools/third_party/s3_management/test_update_dependencies.py was not discovered by the build_tools unit test workflow. Technical Details
Test Plan
Test Result
Submission Checklist
|
HereThereBeDragons
left a comment
There was a problem hiding this comment.
thank you for your contribution
could you please update pr title and description and describing why and what is done in the pr? as they will become the commit message. i guess you could just copy your other message into the description.
otherwise looks good for me if the tests are passing
HereThereBeDragons
left a comment
There was a problem hiding this comment.
looking at the tests:
could you please create a new tests/ folder under s3_management/ and move the file there?
and it then needs to be excluded for the coverage.
you can get inspired by #4107
if you dont want to do those changes (as it more or less what #4107 already has), i would close this pr in favor of #4107
please let me know how you want to continue
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist