Closed
Conversation
9d19ada to
2dab6e2
Compare
marbre
requested changes
Apr 17, 2026
Member
marbre
left a comment
There was a problem hiding this comment.
I am not sure this should go into TheRock or if another home is a better fit. Eventually let's discuss this offline before moving forward here.
Member
There was a problem hiding this comment.
There should be no need to build those from scratch and it could be additional layers on top of our existing manylinux image.
Member
There was a problem hiding this comment.
Same here. This fully duplicated the above where the only change is the CUDA version? This adds an unnecessary maintenance burden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We intend to add NVidia building and testing pipelines. This PR is the first part, providing CUDA images which will be further used in the future pipeline.
Technical Details
We intend to support two versions of CUDA: 12.9 and 13.2. The CUDA image is based on the build_maylinux_x86_64.Dockerfile, only adding cuda-toolkit package.
NOTE: hip-test build and test enablement will be dependent on availability of Nvidia runner.
Test Plan
Test Result
Docker build and hip-tests compilation pass succesfully locally, hip-test build for Nvidia will be provided in a separate PR
Submission Checklist