Skip to content

Add CUDA containers publishing#4636

Closed
litvaOo wants to merge 4 commits intomainfrom
users/dlytovch/add-nvidia-container
Closed

Add CUDA containers publishing#4636
litvaOo wants to merge 4 commits intomainfrom
users/dlytovch/add-nvidia-container

Conversation

@litvaOo
Copy link
Copy Markdown

@litvaOo litvaOo commented Apr 17, 2026

Motivation

We intend to add NVidia building and testing pipelines. This PR is the first part, providing CUDA images which will be further used in the future pipeline.

Technical Details

We intend to support two versions of CUDA: 12.9 and 13.2. The CUDA image is based on the build_maylinux_x86_64.Dockerfile, only adding cuda-toolkit package.

NOTE: hip-test build and test enablement will be dependent on availability of Nvidia runner.

Test Plan

  1. Dockerfile build should pass for both versions
  2. Hip-tests should be able to compile and run using these docker containers

Test Result

Docker build and hip-tests compilation pass succesfully locally, hip-test build for Nvidia will be provided in a separate PR

Submission Checklist

@litvaOo litvaOo force-pushed the users/dlytovch/add-nvidia-container branch from 9d19ada to 2dab6e2 Compare April 17, 2026 12:34
Copy link
Copy Markdown
Member

@marbre marbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this should go into TheRock or if another home is a better fit. Eventually let's discuss this offline before moving forward here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no need to build those from scratch and it could be additional layers on top of our existing manylinux image.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. This fully duplicated the above where the only change is the CUDA version? This adds an unnecessary maintenance burden.

@litvaOo litvaOo closed this Apr 24, 2026
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants