-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix(cli): keep /model switches session-scoped #4332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
qqqys
wants to merge
14
commits into
QwenLM:main
Choose a base branch
from
qqqys:fix/model-session-scope
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
a101ca8
fix(cli): keep model switches session-scoped
qqqys 412c8d6
fix(cli): add model command locale coverage
qqqys ef5e575
test(cli): cover model default review paths
qqqys 0779951
fix(cli): harden model default shortcut
qqqys eab2ece
fix(cli): address model default review feedback
qqqys fd46f47
fix(cli): harden model default persistence
qqqys f832609
fix(cli): polish model default review feedback
qqqys 1faa612
fix(cli): clarify model session default feedback
qqqys 346da6e
fix(cli): handle model default persistence errors
qqqys ce79a71
fix(cli): complete model flag suggestions
qqqys 0b5a1ff
fix(cli): serialize model default switching
qqqys 063fef6
fix(cli): handle fast model persistence failures
qqqys 4b33f7c
fix(cli): stabilize model dialog keypress handler
qqqys f2a49b6
fix(cli): handle model default race cases
qqqys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Critical] This test for unqualified
--default gpt-4only assertsmodel.namebut notsecurity.auth.selectedType. ThepersistMainModelDefaultfunction (line 70) also writessecurity.auth.selectedTypefor unqualified IDs. If that line were accidentally deleted, this test would still pass.The provider-qualified test below correctly asserts both settings.
— qwen-latest-series-invite-beta-v34 via Qwen Code /review