Skip to content

chore: add .github/release.yml to support skip-changelog label #4327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiliang114 merged 3 commits into from
May 20, 2026
+6 −0
Merged

chore: add .github/release.yml to support skip-changelog label #4327

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
499e973
chore: add .github/release.yml to support skip-changelog label
yiliang114 May 19, 2026
448e529
chore: add comments explaining release.yml purpose
yiliang114 May 19, 2026
31ae298
fix(lint): quote string value in release.yml for yamllint
yiliang114 May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Configuration for GitHub's automatic release notes generation
# PRs with 'skip-changelog' label will be excluded from release notes
changelog:
exclude:
Copy link
Copy Markdown
Collaborator

@wenshao wenshao May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] 自动化 release PR 缺少 skip-changelog 标签

三个 release workflow（release.yml、release-sdk.yml、release-sdk-python.yml）会自动创建并合并 chore(release): v0.X.Y 类型的 PR。这些 PR 完全自动化，无人手动添加 skip-changelog，且无关联 issue。结果是每次发版后 1-3 个 chore(release) 条目会出现在下一次 release notes 中——正是此配置想要过滤的噪声。

建议在 release workflow 的 gh pr create 命令中添加 --label "skip-changelog"，或在此处增加 exclude.authors 过滤 CI bot 账号。

— qwen-latest-series-invite-beta-v34 via Qwen Code /review

labels:
Copy link
Copy Markdown
Collaborator

@wenshao wenshao May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] skip-changelog 标签在仓库中目前无自动应用机制。没有任何 workflow、labeler 配置或脚本会自动为 PR 添加此标签。pr-triage.sh 仅从关联 issue 同步标签，不会主动添加 skip-changelog。

建议：

  1. 确认 GitHub 仓库上已创建 skip-changelog 标签
  2. 在 CONTRIBUTING.md 中记录手动添加流程，或考虑添加 .github/labeler.yml 自动为 chore/bot PR 打上此标签

— qwen-latest-series-invite-beta-v34 via Qwen Code /review

Copy link
Copy Markdown
Collaborator Author

@yiliang114 yiliang114 May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

label 用的时候 gh 命令会自动创建。晚点我会批量加。
自动打标签暂时不搞，这个 label 本来就是偶尔手动用一下的，感觉可以不用增加这个逻辑。

- 'skip-changelog'
Copy link
Copy Markdown
Collaborator

@wenshao wenshao May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] pr-triage.sh 会静默移除 skip-changelog 标签

pr-triage.sh（由 gemini-scheduled-pr-triage.yml 每 15 分钟执行）会遍历 PR 上所有标签，移除不在关联 issue 上的标签（仅豁免 status/need-issue）。由于 skip-changelog 是 PR 层面的概念，关联 issue 上不太可能有同名标签，因此维护者手动添加后 15 分钟内就会被静默移除，导致 release notes 排除失效。

建议在 pr-triage.sh 第 81 行的豁免条件中加入 skip-changelog：

if [[ "${label}" != "status/need-issue" && "${label}" != "skip-changelog" ]]; then

— qwen-latest-series-invite-beta-v34 via Qwen Code /review

Loading