-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat(cli): per-turn /diff with interactive dialog #4277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
d88b15e
e01bb3e
da56a8c
9a63bb6
b0428c5
f9667f2
f37d6f3
5cf48b0
1628101
328004b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,6 +48,7 @@ import { MCPManagementDialog } from './mcp/MCPManagementDialog.js'; | |
| import { HooksManagementDialog } from './hooks/HooksManagementDialog.js'; | ||
| import { SessionPicker } from './SessionPicker.js'; | ||
| import { RewindSelector } from './RewindSelector.js'; | ||
| import { DiffDialog } from './DiffDialog.js'; | ||
| import { MemoryDialog } from './MemoryDialog.js'; | ||
| import { Help } from './Help.js'; | ||
| import { BackgroundTasksDialog } from './background-view/BackgroundTasksDialog.js'; | ||
|
|
@@ -472,6 +473,18 @@ export const DialogManager = ({ | |
| ); | ||
| } | ||
|
|
||
| if (uiState.isDiffDialogOpen) { | ||
|
BZ-D marked this conversation as resolved.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Suggestion] No Error Boundary wraps — DeepSeek/deepseek-v4-pro via Qwen Code /review
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Deferring — no The other correctness gates landed in f9667f2 (per-file try/catch in |
||
| return ( | ||
| <DiffDialog | ||
| history={uiState.history} | ||
| cwd={config.getWorkingDir() || config.getProjectRoot()} | ||
| fileHistoryService={config.getFileHistoryService()} | ||
| fileCheckpointingEnabled={config.getFileCheckpointingEnabled()} | ||
| onClose={uiActions.closeDiffDialog} | ||
| /> | ||
| ); | ||
| } | ||
|
|
||
| // Background tasks dialog — lowest priority so other dialogs | ||
| // (permissions, trust prompts, auth, etc.) always take precedence. The | ||
| // dialog is part of the shared dialogsVisible machinery (see | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.