[likelihood_ratio_process.md] Update np.random → Generator API#976
Open
Chihiro2000GitHub wants to merge 1 commit into
Open
[likelihood_ratio_process.md] Update np.random → Generator API#976Chihiro2000GitHub wants to merge 1 commit into
Chihiro2000GitHub wants to merge 1 commit into
Conversation
40 tasks
📖 Netlify Preview Ready!Preview URL: https://pr-976--sunny-cactus-210e3e.netlify.app Commit: 📚 Changed LecturesBuild Info
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates legacy NumPy random API usage in
likelihood_ratio_process.mdas part of QuantEcon/meta#299.A single generator
rng = np.random.default_rng()is defined once in the setup cell and reused throughout, passed explicitly to the simulation functions.Details
rng = np.random.default_rng()in the imports/setup cell and reused it across all main-text cells and simulation functions.np.random.beta→rng.beta,np.random.rand(N)→rng.random(N),np.random.rand(N, T)→rng.random((N, T)), andnp.random.choice(...)→rng.choice(...).rngas an explicit argument through the simulation functions and their wrappers (simulate_likelihood_ratios,simulate_sequences,protocol_1/protocol_2and theircompute_*/analyze_*wrappers,simulate_markov_chain,analyze_markov_chains,compute_markov_selection_error) and updated the call sites.Note for reviewers
simulate_likelihood_ratiosis decorated with@jitbut has noparallel=True/prange, sorngis passed in as an explicit argument (rng.beta) rather than lifting the draws into a precomputed array. Verified locally that this compiles and runs under Numba 0.62.1.rngis defined once in the setup cell rather than at the first point of use, because it is shared across many far-apart sections; a single top-level generator seemed clearer and easier to locate than repeatingdefault_rng()per block.mc.simulateinsidesimulate_markov_chainuses QuantEcon's own internal RNG and is not annp.random.*call, so it is left unchanged (out of scope for this migration).Hi @mmcky and @HumphreyYang, I'd be grateful if you could take a look when you have time.