Verify Descent to Undermountain - #767
Open
tomojira wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifying Descent to Undermountain (1997) (Interplay Productions)
Checklist
Have adequate installation instructions been provided to match any config files in the DOSZ?
The sound config isn't needed in the DOSZ. It can be created by
SETUP.EXE.However, I added a 32 MB mem_size DOS.YML because the game crashes after character creation without it.
Have any official patches been applied, if necessary?
Yes, patch v1.3 was already applied.
Is the game data in the root of the ZIP (unless game does not work that way)?
I moved it to the root.
For games which include CD images, is there a smaller installation variant that offers the same features but needs less files?
Yes, I changed to the Small option. I didn't notice any difference at the beginning.
Is the entry in the right variant file (i.e. Freeware)?
Yes.
Have digital versions (Steam, GOG) been checked for matching?
The game isn't on GOG/Steam.
Can the game benefit from using embedded data or embedded patches in the datfile?
Yes, I added embedded data to the DOS.YML.
Can DoDAT build the game from the install media?
Yes.
If the game requires a yml in the DOSZ, has it been added to the yml folder in the repo?
Yes, it's already there.
Are there .PIF or .ICO or Win32 .EXE files that could be excluded?
No.
Do the file timestamps match the installation media?
No, I added them.
Does the DOSZ run standalone?
Yes.
For CD games, can the game be set up to run without a CD mounted?
There doesn't seem to be a way.
Can the game benefit from using CHDtoOGG?
There are no audio tracks.
Is the game creating a swap file in the .pure.zip that could be avoided by increasing memory size? Or is it creating other bloated files that could be prevented by adding them in the DOSZ?
Many files are created, and one is even around 12 MB. But using the full installation size doesn't prevent this from happening, and the files (e.g.
PORTAL.EGG) don't seem to directly exist on the disc.Does the DOSC contain problematic data (i.e. copyright issue)?
No.
Does the DOSC have copy protection removed, if possible?
There doesn't seem to be copy protection (besides CD check).
Is the game running at the correct speed? Is CPU year specified?
cpu_year: 1997was set, but I unlimited it to maximize the framerate, it runs at 70 FPS with 600,000+ cycles.Is the DOSC auto-running and skipping past any obstructions? Is it updated to use WAITMODECHANGE if possible?
Yes, it was skipping the Interplay logo and opening movie because they play very slowly and stutter. This is a problem with the game itself that every DOSBox fork encounters (only DOSBox-X seems to have a hack to deal with it):
dosbox-staging/dosbox-staging#3635
However, there is a -notitles parameter for the EXE to skip it, so I used that and changed the run_input to just WAITMODECHANGE.
Does the game have MT-32 support? If so, is it correctly using MT-32 (old) or CM-32L (new), going by the Vogons Wiki?
No.
Does the game have General MIDI support?
No.
Is the game set up to run with the best quality graphics options by default?
Yes, it seems to be.
For certain old games only - are the graphics/audio improved by specifying video_card: pcjr, tandy, or generic_cga?
Not applicable.
Does the game have a mouse cursor that benefits from enabling input_directmouse?
It doesn't seem to work with this game.
Does a game with separate episodes/executables have the options named and ordered properly in the DOSZ? Do they use the run_utility feature?
Not applicable.
Does the game share saves with a sequel, expansion, etc? If so, is it updated to use the .savename feature?
Not applicable.
Summary of changes