Skip to content

docs: point security reports at Bugcrowd in the PR template - #1414

Open
ryanio wants to merge 1 commit into
mainfrom
chore/pr-template-comment
Open

docs: point security reports at Bugcrowd in the PR template#1414
ryanio wants to merge 1 commit into
mainfrom
chore/pr-template-comment

Conversation

@ryanio

@ryanio ryanio commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Motivation

The template already keeps its guidance inside HTML comments, so none of it leaks into contributor PR bodies. What it does not say is where to send a security report, and a vulnerability filed as a public pull request or issue is disclosed the moment it is opened.

Solution

One line added to the leading comment block, pointing at https://bugcrowd.com/engagements/opensea. Nothing else changes, and the rendered template is still just the Motivation and Solution headings.

Part of a sweep across the public OpenSea repos. The mirrored packages in opensea-devtools had the opposite problem: their template was plain markdown rather than a comment, so every community PR body opened with our own boilerplate. See opensea-sdk pull requests 1997 through 2000, all opened the same day, each beginning with "Thanks for opening a PR" before the author gets a word in.

Verified by stripping the HTML comments from the file and confirming the remainder is two headings and blank lines.

CI status

The four Forge jobs are red, and they were red before this branch existed. They fail in Install forge dependencies, before a single contract compiles:

Updating dependencies in /home/runner/work/<repo>/<repo>/lib
Error: git checkout exited with code 1: error: pathspec 'v1.5.0' did not match any file(s) known to git

.gitmodules pins lib/forge-std with branch = v1.5.0, but v1.5.0 is a tag upstream, not a branch, and the Foundry nightly these workflows install can no longer resolve it from its shallow clone. The tag itself still exists at foundry-rs/forge-std, so this is toolchain drift rather than a deleted ref.

Every Seaport Test CI and seadrop Test CI run going back months has failed the same way, including dependabot branches that change nothing but a lockfile. Seaport's own main at 0801339, the base of this branch, failed on 2025-09-30. The Hardhat jobs, linters, CodeQL and Socket all pass here.

A markdown file cannot affect forge install. Repinning forge-std or freezing the Foundry version belongs in its own PR, since it touches the toolchain for an audited contract repo.

Adds one line to the template's leading HTML comment so a contributor sees it
while writing the PR and does not file a vulnerability in public.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@ryanio
ryanio force-pushed the chore/pr-template-comment branch from e9ceac8 to d9d9d87 Compare August 25, 2026 16:30
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.26%. Comparing base (4b40a25) to head (d9d9d87).
⚠️ Report is 34 commits behind head on main.

❌ Your project status has failed because the head coverage (97.26%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1414      +/-   ##
==========================================
- Coverage   97.67%   97.26%   -0.42%     
==========================================
  Files          22       21       -1     
  Lines        1379     1279     -100     
  Branches      248      248              
==========================================
- Hits         1347     1244     -103     
+ Misses         25       16       -9     
- Partials        7       19      +12     
Flag Coverage Δ
foundry ?
reference 97.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants