Conversation
c7fa1cd to
3fb337b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4186 +/- ##
=======================================
- Coverage 95.2% 95.1% -0.1%
=======================================
Files 326 326
Lines 16192 16165 -27
Branches 2554 2545 -9
=======================================
- Hits 15413 15364 -49
- Misses 774 796 +22
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3fb337b to
12fc0d0
Compare
lutzhelm
left a comment
There was a problem hiding this comment.
I'm wondering if there is a more than theoretical possibility that any dependent project relies on the reducers for SET_WINDOW_SIZE or UPDATE_WINDOW_POSITION. That would require them to provide their own functions to dispatch those actions. I searched on GitHub and couldn't find any indication, but there might (theoretically!) still be occurrences on different services / private repos.
I think it is quite unlikely, and if people actually run into this issue, we can still advice them to add those reducers in their own code.
If we agree on this, I will merge this PR; I just want to rule out that we are introducing an actually breaking change.
|
I search also for usage in github projects and find nothing on it. @marlo-longley @lutzhelm |
dnoneill
left a comment
There was a problem hiding this comment.
SET_WORKSPACE_FULLSCREEN is still in
mirador/src/state/reducers/workspace.js
Line 61 in e040908
In the process of writing this Wiki documentation page, I realized that several action types were undispatched.
https://github.com/ProjectMirador/mirador/wiki/Architecture-overview-4:-Mirador-state-changes-for-plugin-authors
Happy to discuss, but cleaning up unused actions will make the code easier to understand.