Skip to content

Make miradorImageToolsPlugin the default export for src/index.#62

Open
cbeer wants to merge 1 commit intomainfrom
default-export
Open

Make miradorImageToolsPlugin the default export for src/index.#62
cbeer wants to merge 1 commit intomainfrom
default-export

Conversation

@cbeer
Copy link
Copy Markdown
Contributor

@cbeer cbeer commented Jan 31, 2025

No description provided.

@marlo-longley
Copy link
Copy Markdown
Member

marlo-longley commented Jul 21, 2025

@cbeer I just tried to rebase this and ran into the eslint rule violation import/no-named-as-default which prevents a name conflict between a named export and a default export with the same identifier. Apparently the best practice is to used name exports. I realize our other plugins use default exports. If consistency was the goal with this PR, we could disable the eslint rule, or bring the other plugins (share, download), over to named exports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants