Skip to content

Replace direct np.random.* calls with np.random.RandomState instances #8798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericspod merged 3 commits into from
Apr 13, 2026
+2 −2
Merged

Replace direct np.random.* calls with np.random.RandomState instances #8798

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc1af1c
Replace direct np.random.* calls with np.random.RandomState instances
haoyu-haoyu Mar 31, 2026
2bd0f02
Revert global RNG changes that broke reproducibility
haoyu-haoyu Apr 1, 2026
26b0bee
Merge branch 'dev' into fix/consistent-random-state
ericspod Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions monai/transforms/signal/array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ def __call__(self, signal: NdarrayOrTensor) -> NdarrayOrTensor:
data = convert_to_tensor(self.freqs * time_partial)
sine_partial = self.magnitude * torch.sin(data)

loc = np.random.choice(range(length))
loc = self.R.choice(range(length))
signal = paste(signal, sine_partial, (loc,))

return signal
Expand Down Expand Up @@ -354,7 +354,7 @@ def __call__(self, signal: NdarrayOrTensor) -> NdarrayOrTensor:
time_partial = np.arange(0, round(self.fracs * length), 1)
squaredpulse_partial = self.magnitude * squarepulse(self.freqs * time_partial)

loc = np.random.choice(range(length))
loc = self.R.choice(range(length))
signal = paste(signal, squaredpulse_partial, (loc,))

return signal
Expand Down
Loading