Skip to content

Add data-ps-fragment markers to dynamic fragments #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Codencode wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

Add data-ps-fragment markers to dynamic fragments #1101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CONTEXT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ attributes.
component.
- `data-ps-context="name"`: Identify the current page/scope.
- `data-ps-template="name"`: Reference a template name to use it in JS.
- `data-ps-fragment="name"`: Identify a self-contained dynamic content fragment
for external integrations.

**JavaScript Design Patterns:**

Expand Down
2 changes: 1 addition & 1 deletion templates/_partials/notifications.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*}

{if isset($notifications)}
<div id="notifications">
<div id="notifications" data-ps-fragment="notifications">
<div class="container">
{if $notifications.error}
{block name='notifications_error'}
Expand Down
2 changes: 1 addition & 1 deletion templates/catalog/_partials/product-add-to-cart.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* LICENSE.md file that was distributed with this source code.
*}
{if !$configuration.is_catalog}
<div class="product__add-to-cart-container product-add-to-cart js-product-add-to-cart">
<div class="product__add-to-cart-container product-add-to-cart js-product-add-to-cart" data-ps-fragment="product-add-to-cart">
{block name='product_availability'}
<div
id="product-availability"
Expand Down