Respect the country tax label setting on the product page - #1098
Draft
boo-code wants to merge 1 commit into
Draft
Conversation
The product page showed "No tax" whenever taxes were disabled, without consulting the country's "Display tax label" setting that the branch just below it already honoured. A merchant who turned that label off still saw a tax statement on every product. Gate both branches on the setting, the way #25882 did for the cart summary and the order confirmation table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$configuration.display_taxes_labelis$this->context->country->display_tax_label(FrontController::getDisplayTaxesLabel()), so a merchant who turns that checkbox off still gets a tax statement on every product page. Both branches are now gated on the setting.Before
After
Why this shape
PrestaShop/PrestaShop#25882 fixed the same defect for the cart summary and the
order confirmation table by gating on
display_taxes_labeltogether withtaxes_enabled, and was mergedin October 2021. The product page was not part of it, which is why the issue is still open with this exact
template quoted in the thread. Using the same gate keeps the three places consistent rather than inventing
a rule for this one.
Scope
Only the product page template changes. The cart summary and the order confirmation table already respect
the setting since PrestaShop/PrestaShop#25882, and so does
DeliveryOptionsFinder.Companion to the same change in
classic-theme: the two themes carry the same template and the same defect.