Escape spaces in OutputFilePath before passing to Export-PSGraph - #53
Closed
claw0ry wants to merge 1 commit into
Closed
Escape spaces in OutputFilePath before passing to Export-PSGraph#53claw0ry wants to merge 1 commit into
claw0ry wants to merge 1 commit into
Conversation
Contributor
Author
|
This was clearly not tested enough by me. PSGraph includes the backticks in filename and cannot find folders since its treating the backticks literally. Essentially the problem is with PSGraph not supporting spaces in filepaths. There is a PR open in the PSGraph repository (KevinMarquette/PSGraph#102) for replacing Invoke-Expression with Invoke-Item which does support spaces in filepaths. Better wait for PSGraph to update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where an error is thrown when you use Export-AzViz with a filepath that contains spaces and the
-Showargument is passed.This error occurs because
Export-PSGraph, when-Showis $true, will useInvoke-Expressionto try to open the file in the systems default application. Invoke-Expression does not support spaces.