fix: format of IPv6 address logged at PostgREST startup#4291
Merged
Conversation
taimoorzaeem
force-pushed
the
fix/ipv6-log-msg
branch
from
3441589 to
8d100d3
Compare
The IPv6 address logged at the startup like `::1:80` was wrong because the port isn't clearly separated. This commit corrects it, now logging as `[::1]:80`. This is done in accordance to RFC 3986. In short, we did this have a clear separation between the port and host because the components of an IPv6 are separated with the ':' character. Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>
taimoorzaeem
force-pushed
the
fix/ipv6-log-msg
branch
from
8d100d3 to
a825f26
Compare
steve-chavez
approved these changes
Aug 29, 2025
Member
|
Backported to v13. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IPv6 address logged at the startup like
::1:80was wrong because the port isn't clearly separated. This commit corrects it, now logging as[::1]:80as discussed in #4288 (comment).This also allows the refactor on #4288 to go smoothly without changing any behavior.