Skip to content

demo: We have not been testing against pg 9.6 and pg 10 for a while#3222

Closed
wolfgangwalther wants to merge 1 commit into
PostgREST:mainfrom
wolfgangwalther:no-pg-96-10
Closed

demo: We have not been testing against pg 9.6 and pg 10 for a while#3222
wolfgangwalther wants to merge 1 commit into
PostgREST:mainfrom
wolfgangwalther:no-pg-96-10

Conversation

@wolfgangwalther
Copy link
Copy Markdown
Member

This was introduced in #2479 and ever since the following is happening:

% postgrest-with-postgresql-9.6 psql -c 'SELECT version()'
                                    version
--------------------------------------------------------------------------------
 PostgreSQL 11.21 on x86_64-pc-linux-gnu, compiled by gcc (GCC) 12.3.0, 64-bit
(1 row)

% postgrest-with-postgresql-10 psql -c 'SELECT version()'
                                    version
-------------------------------------------------------------------------------
 PostgreSQL 11.21 on x86_64-pc-linux-gnu, compiled by gcc (GCC) 12.3.0, 64-bit
(1 row)

So we have not been testing against v9.6 or v10.0 for more than a year now, but instead tested against v11 3x as much.

Locally, tests for both version started to fail after the change. It looks like there are only test-related failures, but I don't plan on fixing them. This PR is to serve as a demonstration only and I will pick up #2052 again.

@wolfgangwalther wolfgangwalther marked this pull request as draft February 10, 2024 17:06
@steve-chavez
Copy link
Copy Markdown
Member

😮 We should test the output of select version() to prevent this from happening.

I'll fix the tests.

@wolfgangwalther
Copy link
Copy Markdown
Member Author

I'll fix the tests.

That's not worth it. We agreed in #2052 (comment) to drop support for old pg versions one year after EOL. This is the case for both 9.6 and 10. I will follow through on that.

@wolfgangwalther
Copy link
Copy Markdown
Member Author

Closing since this was just as a demonstration. Work on the issue is in #2052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants