demo: We have not been testing against pg 9.6 and pg 10 for a while#3222
Closed
wolfgangwalther wants to merge 1 commit into
Closed
demo: We have not been testing against pg 9.6 and pg 10 for a while#3222wolfgangwalther wants to merge 1 commit into
wolfgangwalther wants to merge 1 commit into
Conversation
Member
|
😮 We should test the output of I'll fix the tests. |
Member
Author
That's not worth it. We agreed in #2052 (comment) to drop support for old pg versions one year after EOL. This is the case for both 9.6 and 10. I will follow through on that. |
Member
Author
|
Closing since this was just as a demonstration. Work on the issue is in #2052 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was introduced in #2479 and ever since the following is happening:
So we have not been testing against v9.6 or v10.0 for more than a year now, but instead tested against v11 3x as much.
Locally, tests for both version started to fail after the change. It looks like there are only test-related failures, but I don't plan on fixing them. This PR is to serve as a demonstration only and I will pick up #2052 again.