Skip to content

nix: Remove deprecation warning for dockerTools.buildImage { contents }#2541

Merged
wolfgangwalther merged 1 commit into
PostgREST:mainfrom
wolfgangwalther:nix-build
Oct 27, 2022
Merged

nix: Remove deprecation warning for dockerTools.buildImage { contents }#2541
wolfgangwalther merged 1 commit into
PostgREST:mainfrom
wolfgangwalther:nix-build

Conversation

@wolfgangwalther
Copy link
Copy Markdown
Member

Whenever we push to main right now, the cachix push job fails: https://github.com/PostgREST/postgrest/actions/runs/3338831343/jobs/5527008514

While looking at it, I noticed the deprecation warning for $subject. Changed that here. Couldn't find any problem with pushing to cachix, though. I just set up the auth token for the first time and pushed successfully from my local machine.

@steve-chavez any idea why it's currently failing on main? This will prevent us from doing a release, I think.

I will merge this fix when CI ran through and see whether it changes anything... but I don't expect it to.

Signed-off-by: Wolfgang Walther <walther@technowledgy.de>
@wolfgangwalther wolfgangwalther merged commit 88b5966 into PostgREST:main Oct 27, 2022
@wolfgangwalther wolfgangwalther deleted the nix-build branch October 27, 2022 17:51
@wolfgangwalther
Copy link
Copy Markdown
Member Author

Didn't change anything: https://github.com/PostgREST/postgrest/actions/runs/3339559728/jobs/5528657687

@monacoremo can you have a look at that failure? Any idea?

@steve-chavez
Copy link
Copy Markdown
Member

Hm, we didn't change anything from cachix so it must have been an upstream change.

Not sure, but maybe bumping the versions of cachix actions could help

    - uses: cachix/install-nix-action@v16
    - uses: cachix/cachix-action@v10

@wolfgangwalther
Copy link
Copy Markdown
Member Author

Not sure, but maybe bumping the versions of cachix actions could help

Wait.. why didn't dependabot create PRs for some updates?

At least cachix-action v11 is out for 15 days already.. and v10 says something about some "broken installs": https://github.com/cachix/cachix-action/releases

Ah, same thing for install-nix-action... https://github.com/cachix/install-nix-action/releases

@wolfgangwalther
Copy link
Copy Markdown
Member Author

Nope, updating those didn't help. Same error. Any other ideas, @steve-chavez, @monacoremo? Does pushing to cachix work for you guys locally, too?

@steve-chavez
Copy link
Copy Markdown
Member

@wolfgangwalther Yes, postgrest-push-cachix works for me.

export CACHIX_AUTH_TOKEN=".."

$ postgrest-push-cachix
warning: you did not specify '--add-root'; the result might be removed by the garbage collector
compressing and pushing /nix/store/2nnigqlzdvymqdj7g7d5j6zrcvryywnl-postgrest-10.0.0.20221011.drv (13.77 KiB)
compressing and pushing /nix/store/83bx7j4ra2ydd579bxy89bcc021965rm-postgrest-docker-load.drv (2.88 KiB)
compressing and pushing /nix/store/80mav1bvbaixmzxz9vnqvwizay5pq9jq-postgrest-10.0.0.20221011.drv (14.23 KiB)
compressing and pushing /nix/store/g65ah4nfialrh0bc8r39qnf7whhf592m-docker-image-postgrest.tar.gz.drv (7.54 KiB)
compressing and pushing /nix/store/j3jbjl7ki1kcyc2h8cl3cwm0k70s72g2-runtime-deps.drv (1.71 KiB)
compressing and pushing /nix/store/jnvx261k6v9s8xr073pch3zyg50krdpn-docker-layer-postgrest.drv (3.05 KiB)
compressing and pushing /nix/store/n46chn4yjxhpncb213zq0l48rv7jjr5h-postgrest-10.0.0.20221011.drv (13.94 KiB)
compressing and pushing /nix/store/na0i6mr01zri3lhd1ssx58h7sl644rzf-postgrest-docker.drv (2.04 KiB)
compressing and pushing /nix/store/qavcnzshp7cgyaj9bgi4aym1psdxn57b-postgrest-memory.drv (2.04 KiB)
compressing and pushing /nix/store/xackmnn9xpr2kcvxl4ckd1fzp7dxrfrd-postgrest-test-memory.drv (3.55 KiB)
compressing and pushing /nix/store/zd91zsalknyg9mwnp49cqirylfpjgrv8-source (836.34 KiB)
All done.

Perhaps #2479 is related? Could we merge that one and see if it clears something for cachix?

@wolfgangwalther
Copy link
Copy Markdown
Member Author

Perhaps #2479 is related? Could we merge that one and see if it clears something for cachix?

I'm going to build that on my machine, push it to cachix and then see whether CI passes. Otherwise the build job might time out again.

@wolfgangwalther
Copy link
Copy Markdown
Member Author

Updating nixpkgs fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants