Skip to content

feat(sig): Inbox toolbar disabled clarity#1531

Merged
Twixes merged 2 commits intomainfrom
twix/inbox-row-visuals
Apr 8, 2026
Merged

feat(sig): Inbox toolbar disabled clarity#1531
Twixes merged 2 commits intomainfrom
twix/inbox-row-visuals

Conversation

@Twixes
Copy link
Copy Markdown
Member

@Twixes Twixes commented Apr 7, 2026

Problem

It is really key that it's clear why a button is disabled. Otherwise you hover on something like below that appears clickable, but frustratingly nothing happens:

CleanShot 2026-04-08 at 08.51.36@2x.png

Changes

Importing the disabledReason tooltip solution from the main PostHog app - the tooltip explains what's going on:

CleanShot 2026-04-08 at 08.53.44@2x.png

Also fixes a bug where we said "5 report snoozeds" instead of "5 reports snoozed".

Also, giving the checkbox hover and active style to create joy and clarity in interaction.

Copy link
Copy Markdown
Member Author

Twixes commented Apr 7, 2026

@Twixes Twixes force-pushed the twix/inbox-row-visuals branch from c53762d to f96bd7a Compare April 7, 2026 19:57
@Twixes Twixes force-pushed the twix/inbox-chrome-polish branch 2 times, most recently from 49f9daf to 6755a6a Compare April 7, 2026 20:00
@Twixes Twixes force-pushed the twix/inbox-row-visuals branch from f96bd7a to 3971708 Compare April 7, 2026 20:00
@Twixes Twixes changed the title Refactor report row visuals and add Button component with disabled-reason tooltip style(sig): Make inbox selection controls self-explanatory Apr 7, 2026
@Twixes Twixes changed the title style(sig): Make inbox selection controls self-explanatory feat(sig): Make inbox selection controls self-explanatory Apr 7, 2026
@Twixes Twixes force-pushed the twix/inbox-row-visuals branch 2 times, most recently from ae4d475 to 57e72a2 Compare April 7, 2026 21:18
@Twixes Twixes changed the title feat(sig): Make inbox selection controls self-explanatory feat(sig): Inbox toolbar Apr 7, 2026
@oliverb123 oliverb123 force-pushed the twix/inbox-chrome-polish branch from 6755a6a to b21ead6 Compare April 7, 2026 21:51
@oliverb123 oliverb123 force-pushed the twix/inbox-row-visuals branch from 57e72a2 to 8e02e34 Compare April 7, 2026 21:51
@Twixes Twixes changed the title feat(sig): Inbox toolbar feat(sig): Inbox toolbar disabled clarity Apr 8, 2026
@Twixes Twixes force-pushed the twix/inbox-chrome-polish branch from b21ead6 to 142be2c Compare April 8, 2026 06:16
@Twixes Twixes force-pushed the twix/inbox-row-visuals branch from 8e02e34 to da7746d Compare April 8, 2026 06:16
@Twixes Twixes marked this pull request as ready for review April 8, 2026 06:53
@Twixes Twixes force-pushed the twix/inbox-row-visuals branch from da7746d to 41031df Compare April 8, 2026 08:38
@Twixes Twixes requested review from a team April 8, 2026 08:40
Copy link
Copy Markdown
Member Author

Twixes commented Apr 8, 2026

Tagging @team-code and @adamleithp, as we're adding a new Button component here

Copy link
Copy Markdown
Member Author

Twixes commented Apr 8, 2026

Merge activity

  • Apr 8, 10:43 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 8, 10:56 AM UTC: Graphite couldn't merge this PR because it had merge conflicts.
  • Apr 8, 2:18 PM UTC: @Twixes merged this pull request with Graphite.

@Twixes Twixes changed the base branch from twix/inbox-chrome-polish to graphite-base/1531 April 8, 2026 10:45
@Twixes Twixes changed the base branch from graphite-base/1531 to main April 8, 2026 10:54
@Twixes Twixes force-pushed the twix/inbox-row-visuals branch from 41031df to 2c6c682 Compare April 8, 2026 11:51
@Twixes Twixes merged commit d044bac into main Apr 8, 2026
16 checks passed
@Twixes Twixes deleted the twix/inbox-row-visuals branch April 8, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants