Repository navigation
Make it possible to define multiple selectionRules for a block - #2987
Merged
IntegratedQuantum merged 15 commits intoMay 8, 2026
Merged
IntegratedQuantum merged 15 commits into
IntegratedQuantum merged 15 commits into
Conversation
Wunka
suggested changes
May 1, 2026
Wunka
left a comment
Wunka
left a comment
Contributor
There was a problem hiding this comment.
Maybe never can just be the empty list?
But you don't have to follow up on that.
Contributor
Author
Good idea! Then the whole check can go. It's a valid state anyway |
DellieDelta
force-pushed
the
selection-rule-to-selection-rules
branch
from
May 2, 2026 12:02
b8fc50e to
11401d4
Compare
Wunka
suggested changes
May 3, 2026
Wunka
suggested changes
May 4, 2026
Wunka
approved these changes
May 4, 2026
IntegratedQuantum
requested changes
May 6, 2026
…zon.zig to make nullable enums possible as type)
DellieDelta
force-pushed
the
selection-rule-to-selection-rules
branch
from
May 7, 2026 15:23
771b0e1 to
98dce60
Compare
DellieDelta
force-pushed
the
selection-rule-to-selection-rules
branch
from
May 7, 2026 15:33
98dce60 to
951867d
Compare
IntegratedQuantum
requested changes
May 7, 2026
IntegratedQuantum
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #2983
To make both the selectionRules
.toolEffectiveand.placeablepossible on the same block, in preparation for adding buckets (#627)Also rename it to selectionCapabilities, because it's clearer that any being true will lead to the block being selected