Repository navigation
Add a check for unused private declarations - #8
Merged
IntegratedQuantum merged 8 commits intoJul 19, 2026
Merged
Conversation
Wunka
suggested changes
May 30, 2026
Closed
…ld discourage using imports)
IntegratedQuantum
force-pushed
the
unused_declarations
branch
from
July 19, 2026 09:13
190f7a6 to
b373081
Compare
Wunka
suggested changes
Jul 19, 2026
Comment on lines
+11
to
+12
| identifiers.put(main.allocator, "std", {}) catch @panic("OOM"); | ||
| identifiers.put(main.allocator, "main", {}) catch @panic("OOM"); |
Contributor
There was a problem hiding this comment.
Suggested change
| identifiers.put(main.allocator, "std", {}) catch @panic("OOM"); | |
| identifiers.put(main.allocator, "main", {}) catch @panic("OOM"); |
Without this, this also works.
Else you would have to add every import we ever do. Like c etc
Member
Author
There was a problem hiding this comment.
Right, now that I ignore all imports anyways this is no longer needed
IntegratedQuantum
added a commit
to PixelGuys/Cubyz
that referenced
this pull request
Jul 19, 2026
In preparation for PixelGuys/Cubyz-linter#8
Wunka
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see many PRs that eventually generate an unused container-level variable or function somewhere.
This does however have the (possibly annoying) side effect of having to clean up the import section.
fixes #17