Skip to content

Allow SW.ShowCameo and SW.ManualFire to work independently of SW.AutoFire - #2335

Open
DeathFishAtEase wants to merge 6 commits into
Phobos-developers:developfrom
DeathFishAtEase:AutoFireExt
Open

Allow SW.ShowCameo and SW.ManualFire to work independently of SW.AutoFire#2335
DeathFishAtEase wants to merge 6 commits into
Phobos-developers:developfrom
DeathFishAtEase:AutoFireExt

Conversation

@DeathFishAtEase

Copy link
Copy Markdown
Collaborator

In Ares, SW.ShowCameo and SW.ManualFire only worked when SW.AutoFire=true; this restriction was already baseless, and with more superweapon release methods available in modern times, it has unnecessarily burdened modders with extra handling, such as enabling these two via SW.AutoFire and then disabling SW.AutoFire's own functionality with SW.AITargeting=None. Now they have been decoupled.


The initial commit of this PR is in RAW style, serving as a fallback with minimal changes.

@DeathFishAtEase DeathFishAtEase self-assigned this Aug 10, 2026
@DeathFishAtEase DeathFishAtEase added Needs testing ⚙️T1 T1 maintainer review is sufficient Interaction Something related to interaction with other extension, program etc. labels Aug 10, 2026
@phoboscn-bot

Copy link
Copy Markdown

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户:
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息:

https://www.phoboscn.top/t/topic/705/1

@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Comment thread src/Misc/Hooks.Ares.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Interaction Something related to interaction with other extension, program etc. Needs testing ⚙️T1 T1 maintainer review is sufficient

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants