Add veteran and elite reload time customization with \RELOAD\ and \EMPTY_RELOAD\ abilities - #2334
Open
NukeAtty wants to merge 3 commits into
Open
Conversation
|
To Chinese users:
|
|
To Chinese users:
|
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
TaranDahl
approved these changes
Aug 11, 2026
| // It's not recommended to do anything more here it could have a better place for performance consideration | ||
| void TechnoExt::OnEarlyUpdate() | ||
| { | ||
| this->ApplyPendingReloadVeterancy(); |
Contributor
There was a problem hiding this comment.
I suppose this should be applied like the ROF multiplier. Why do you implement it like that?
TaranDahl
requested changes
Aug 11, 2026
TaranDahl
left a comment
TaranDahl
left a comment
Contributor
There was a problem hiding this comment.
Wrong decision in the last review.
NukeAtty
force-pushed
the
feature/veteran-reload-abilities
branch
from
August 11, 2026 14:47
fd67df4 to
05e9d4c
Compare
…_RELOAD abilities
Rework per review feedback: instead of recording a pending adjustment in the StartReloading hook and scaling ReloadTimer on the next frame's early update, override the reload duration in EAX right before it is written to TimeLeft, the same way the ROF multiplier is applied. Two hooks cover the empty-clip (EmptyReload) and normal (Reload) reload cycles in TechnoClass::StartReloading.
Restore the maintainer's translation fix to the Nuke credits entry.
NukeAtty
force-pushed
the
feature/veteran-reload-abilities
branch
from
August 11, 2026 14:59
95eccdb to
32799f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two new veterancy abilities and their duration multipliers:
RELOAD- scales the duration of normal reload cycles.EMPTY_RELOAD- scales the duration of the empty-clip reload cycle, which is only used when the TechnoType has a positiveEmptyReload.Both abilities are read from the vanilla
VeteranAbilities/EliteAbilitieslists and accumulate the same way as vanilla abilities (Veteran abilities keep working at elite level, Elite abilities are added on top).New INI tags:
The multipliers are applied to the final reload duration computed by the game, so other reload modifiers such as
ReloadIncrementare still taken into account. They only affect newly started reload cycles, and a multiplier of1.0(the default) leaves vanilla behavior unchanged.Tested in-game: both
RELOADandEMPTY_RELOADverified for Veteran/Elite ranks, and mixed lists with vanilla abilities (e.g.VeteranAbilities=STRONGER,RELOAD) confirmed to keep the vanilla abilities working.Documentation, changelog and credits updated.