Experiment with removing moving check from ReadyToNextMission - #2332
Conversation
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
|
add a toggle |
# Conflicts: # src/Ext/Rules/Body.cpp # src/Ext/Rules/Body.h
|
the Jumpjet handling of ApproachTarget.StopWhenInRange has been restored to the old version, otherwise it'll rotate when executing the stop process the OpenTopped issue seems to be fixed, and no other issue is found other than these 2 so far. Gonna merge it first after some more test to solve the immediate problem, and then we can observe more to decide whether we should turn this change on or off by default |
|
I think it's best to only call StopMoving here. That extra handling should actually be a new Feature of JumpjetLocomotion (more code is required to make it work fully correctly elsewhere). |
This is a follow up of #2088. Before a techno is going to switch to another mission, it'll check if it's currently moving. While it's problematic for Jumpjet and Hover already, there's also the question that whether this is really needed
Make a PR for testing the behavior of its removal first, and then we can decide if we could just remove this check directly, or make it an option with an ini toggle, or not doing it at all. No issue has been found in my local test so far, but more test is needed under different scenarios
[General] -> ReadyToNextMission.MovingCheckto true to disable the fix.