Skip to content

Upgrade to polkadot-v1.5.0#1494

Merged
jasl merged 5 commits into
masterfrom
upgrade-polkadot-v1.5.0
Dec 26, 2023
Merged

Upgrade to polkadot-v1.5.0#1494
jasl merged 5 commits into
masterfrom
upgrade-polkadot-v1.5.0

Conversation

@jasl

@jasl jasl commented Dec 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Breaking change:

IMPORTANT:

@jasl

jasl commented Dec 25, 2023

Copy link
Copy Markdown
Contributor Author 
error[E0432]: unresolved import `sp_consensus_grandpa::VersionedAuthorityList`
  --> standalone/pherry/src/lib.rs:23:50
   |
23 | use sp_consensus_grandpa::{AuthorityList, SetId, VersionedAuthorityList};
   |                                                  ^^^^^^^^^^^^^^^^^^^^^^ no `VersionedAuthorityList` in the root

For more information about this error, try `rustc --explain E0432`.
error: could not compile `pherry` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...

@kvinwang

@jasl jasl mentioned this pull request Dec 25, 2023
Open
h4x3rotab
h4x3rotab approved these changes Dec 25, 2023
View reviewed changes
Comment thread standalone/node/src/command.rs
Ok((cmd.run(client, backend, Some(aux_revert)), task_manager))
})
}
#[cfg(feature = "try-runtime")]

@h4x3rotab h4x3rotab Dec 25, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is try-runtime completely removed?

@jasl jasl Dec 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to https://github.com/paritytech/try-runtime-cli
This will be the last version that has try-runtime (they plan to remove it after Jan 2024), but it needs to update a few codes, I'm lazy and thinking we could migrate to new tool now if we need the feature

kvinwang
kvinwang approved these changes Dec 26, 2023
View reviewed changes

@kvinwang kvinwang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvinwang kvinwang mentioned this pull request Dec 26, 2023
Open
7 tasks
@jasl
jasl merged commit 8c7d16e into master Dec 26, 2023
@jasl
jasl deleted the upgrade-polkadot-v1.5.0 branch December 26, 2023 11:39
@kvinwang kvinwang mentioned this pull request Jan 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@h4x3rotab h4x3rotab h4x3rotab approved these changes
@kvinwang kvinwang kvinwang approved these changes
@nanometerzhu nanometerzhu Awaiting requested review from nanometerzhu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jasl @h4x3rotab @kvinwang