Fix cross-platform Cargo workspace modeling#6761
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe changes gate platform-specific crates and native audio dependencies by target, update Compose FFI calls for current engine APIs, align a codegen test helper with the current compile options, and document workspace build behavior. ChangesPlatform target gating
Compose FFI updates
Workspace and tooling cleanup
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/perry-container-compose/src/ffi.rs`:
- Around line 145-147: Update the services parsing in the FFI entrypoint to
distinguish absent or empty filters from malformed JSON. When a non-empty
service filter fails to parse as a JSON array of strings, return json_err(...)
instead of defaulting to an empty Vec; preserve the existing empty-filter
behavior that allows ComposeEngine::logs to request all services.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: d042454e-99c3-46f6-92f5-288e03bd7d38
📒 Files selected for processing (25)
Cargo.tomlchangelog.d/6761-multiplatform-workspace.mdcrates/perry-audio-miniaudio/Cargo.tomlcrates/perry-audio-miniaudio/build.rscrates/perry-audio-miniaudio/src/lib.rscrates/perry-codegen/tests/i64_spec_ternary_recursion.rscrates/perry-container-compose/src/ffi.rscrates/perry-ui-android/Cargo.tomlcrates/perry-ui-android/src/lib.rscrates/perry-ui-gtk4/Cargo.tomlcrates/perry-ui-gtk4/src/lib.rscrates/perry-ui-ios/Cargo.tomlcrates/perry-ui-ios/src/lib.rscrates/perry-ui-macos/Cargo.tomlcrates/perry-ui-macos/src/lib.rscrates/perry-ui-tvos/Cargo.tomlcrates/perry-ui-tvos/src/lib.rscrates/perry-ui-visionos/Cargo.tomlcrates/perry-ui-visionos/src/lib.rscrates/perry-ui-watchos/Cargo.tomlcrates/perry-ui-watchos/src/lib.rscrates/perry-ui-windows-winui/Cargo.tomlcrates/perry-ui-windows-winui/src/lib.rscrates/perry-ui-windows/Cargo.tomlcrates/perry-ui-windows/src/lib.rs
💤 Files with no reviewable changes (1)
- crates/perry-codegen/tests/i64_spec_ternary_recursion.rs
Summary
Validation
cargo metadata --no-deps --format-version 1cargo fmt --all -- --checkcargo checkcargo check --workspace --all-targets --all-featurescargo check -p perry --no-default-features --features dev-clicargo test -p perry-codegen --test i64_spec_ternary_recursionPlatform note
A Windows MSVC cross-check from macOS still requires the Windows C/C++ SDK headers. This change does not install or emulate foreign platform SDKs. Platform CI continues to validate each native distribution target.
Summary by CodeRabbit