Implement interface injection on NeoForge#211
Closed
MaxNeedsSnacks wants to merge 1 commit intoPaperMC:mc/1.21from
Closed
Implement interface injection on NeoForge#211MaxNeedsSnacks wants to merge 1 commit intoPaperMC:mc/1.21from
MaxNeedsSnacks wants to merge 1 commit intoPaperMC:mc/1.21from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was relatively easy to implement as ModDevGradle already supports interface injection, though with a slightly different format to Fabric's.
I also had to add an ItemHoverEventSource interface since custom classes with generic arguments (and on top of that an inner class as generic argument) don't work properly yet (see neoforged/JavaSourceTransformer#53).
Because of that, the mixin and fabric.mod.json were changed to that interface, as well.
This change should be able to be backported to older versions as well, but I don't think there exists a branch for the legacy 1.21 NeoForge codebase...? Either way, not a big deal since it's just explicit vs. implicit casts