fix: killing server during startup crashes it#13755
Open
Strokkur424 wants to merge 1 commit intoPaperMC:dev/26.1from
Open
fix: killing server during startup crashes it#13755Strokkur424 wants to merge 1 commit intoPaperMC:dev/26.1from
Strokkur424 wants to merge 1 commit intoPaperMC:dev/26.1from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a problem often encountered during rapid starting/stopping of servers in debug environments. If you kill the server process, which runs the shutdown hooks, during the server's startup, instead of gracefully shutting down, the server throws an
IllegalStateException. This is due to an attempted async save on the player list.The fix introduced in this PR consists of two parts:
cancelStartupboolean variable, which tells the server to cancel loading/enabling any additional plugins to not waste any time.cancelStartupis set.This variable is set at the start of the main shutdown hook. In my testing this correctly ensured that no matter when a server is restarted, it was never exited in an unsafe state (i.e. any world folder locks left due to no cleanup).