feat: implement 10K review cap enforcement with session summaries#189
Open
djanderson26 wants to merge 3 commits into
Open
feat: implement 10K review cap enforcement with session summaries#189djanderson26 wants to merge 3 commits into
djanderson26 wants to merge 3 commits into
Conversation
- Add pruneOldReviews(userId) to ReviewRepository - Deletes oldest reviews beyond 10K threshold per user - Runs in database transaction for consistency - Returns count of deleted rows
#133) - Add card state tracking (_newCount, _learningCount, _reviewCount) - Implement _finalizeSession() to create and persist ReviewSessionSummary - Call pruneOldReviews() after each session to enforce 10K cap - Trigger review pruning on both normal exit and early termination - Schedule sync push after session finalization
- Test: no pruning under 10K reviews - Test: correct capping at 10K threshold - Test: oldest reviews deleted while newest kept - Test: multi-user isolation - Test: edge cases (empty userId, non-existent user)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements review data rework (#133):
pruneOldReviews(userId)to ReviewRepository to enforce 10K per-user limitCloses #133