Skip to content

feat: add build argument for PACA_VERSION in Dockerfile and CD workflow - #337

Merged
pikann merged 1 commit into
masterfrom
feature/add-build-argument-for-paca-version
Jul 27, 2026
Merged

feat: add build argument for PACA_VERSION in Dockerfile and CD workflow#337
pikann merged 1 commit into
masterfrom
feature/add-build-argument-for-paca-version

Conversation

@pikann

@pikann pikann commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • API reads its running version from the PACA_VERSION env var (defaults to dev), used by /api/version to power the "new version available" banner — but nothing set it, so self-hosted images always reported dev.
  • Add ARG PACA_VERSION=dev / ENV PACA_VERSION=$PACA_VERSION to services/api/Dockerfile so the value is baked into the image at build time.
  • Pass PACA_VERSION=${{ github.event.release.tag_name }} as a build-arg in the api-image job of cd.yml, so each published GitHub Release stamps its image with the matching tag (e.g. v1.2.3).

Test plan

  • docker build --build-arg PACA_VERSION=v9.9.9-test . → container reports PACA_VERSION=v9.9.9-test
  • docker build . (no build-arg, as in local/dev) → container reports PACA_VERSION=dev

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — wires the existing PACA_VERSION env var into the Docker build and CD pipeline so release images report their correct version tag.

  • Add ARG PACA_VERSION=dev / ENV PACA_VERSION=$PACA_VERSION to services/api/Dockerfile — placed in the runtime stage (not build), since the version is read at startup rather than linked at compile time.
  • Pass PACA_VERSION=${{ github.event.release.tag_name }} in cd.yml — the api-image job already runs only on release: published, so the tag is always defined.

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) | 𝕏

@pikann
pikann merged commit e611c34 into master Jul 27, 2026
4 checks passed
@pikann
pikann deleted the feature/add-build-argument-for-paca-version branch July 27, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant