Repository navigation
Make developer_token optional and omit the header when unset - #550
Open
WalkingBad wants to merge 4 commits into
Open
WalkingBad wants to merge 4 commits into
WalkingBad wants to merge 4 commits into
Conversation
Google Ads API access levels are attached to the Google Cloud project that owns the OAuth client since September 2026. The API ignores the developer token value when present and will reject the header in a future major version, while an empty header is still refused with DEVELOPER_TOKEN_PARAMETER_MISSING. Send the header only when a value is configured; existing callers that pass developer_token are unchanged. Verified against the live API with the header absent: listAccessibleCustomers, a GAQL query and generateKeywordHistoricalMetrics all succeed.
Resolve conflicts with the v25.1 release: - CHANGELOG.md: keep the pending entry above the 25.1.0 section - README.md: keep the developer_token note alongside the new optional client settings list - src/service.spec.ts: take master's ESM imports (.js suffixes); master already imports Customer
Docs: - README: move the note into the optional client settings list and correct it (an empty token is omitted too, not only an absent one); drop the token from the listAccessibleCustomers snippet - examples/basic: drop the token from both runnable examples - CHANGELOG: version the entry as 25.1.1, describe the empty-string behaviour accurately, and note the ClientOptions type change under Breaking Changes - client.ts JSDoc: say empty behaves like unset - service.ts: keep only the comment that justifies the truthiness check Tests: - callHeaders: keep login/linked customer ids in the fixture so an early return cannot pass, cover unset and empty tokens, use toStrictEqual - request headers: assert the header on the outgoing REST request, with and without a token
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
developer_tokenoptional inClientOptionsand omits thedeveloper-tokenheader when it is not configured.Since September 2026 the Google Ads API attaches access levels to the Google Cloud project that owns the OAuth client rather than to a developer token (policy page). The API now ignores the token value and states that a future major version will reject the header outright. Because this library always sets the header key, an unset
developer_tokencurrently goes out as the string"undefined"(through gax's${value}stringification) — accepted today, but the wrong long-term shape.Behaviour
developer_tokenset → unchanged, the header is sent as before.developer_tokenabsent → nodeveloper-tokenheader (gRPC metadata and REST alike, since both readcallHeaders).CallHeaders["developer-token"]becomes optional.Note for reviewers: an empty header is still refused by the API with
DEVELOPER_TOKEN_PARAMETER_MISSING, whereas an absent header is accepted. That is why the header is dropped rather than sent empty.Verification
jest: 189/189 (new spec asserts the header is absent when the option is unset).tscclean;eslintreports only the 4 pre-existingno-explicit-anywarnings.listAccessibleCustomers, a GAQLquery, andkeywordPlanIdeas.generateKeywordHistoricalMetricsall succeed.🤖 Generated with Claude Code