feat(build): STEP 5: shared pip-buildenv for Opentrons app recipes#352
Open
neo-jesse wants to merge 1 commit into
Open
feat(build): STEP 5: shared pip-buildenv for Opentrons app recipes#352neo-jesse wants to merge 1 commit into
neo-jesse wants to merge 1 commit into
Conversation
Add PIP_CACHE_DIR, a flock-guarded shared host pip-buildenv, and per-recipe private pip caches to cut parallel do_compile contention. Co-authored-by: Cursor <cursoragent@cursor.com>
neo-jesse
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PIP_CACHE_DIRinopentrons_app_bundle.bbclass.pip-buildenvacross parallel server recipes when the cache dir is set.do_compile, then merge back under flock to avoid pip lock contention.--no-binary :all:by default via overridableOPENTRONS_APP_BUNDLE_PIP_NO_BINARY.oelint-constants.json; setPIP_CACHE_DIRin CIlocal.conf.Test plan
opentrons_app_bundle.bbclassdo_compilewall is not worse than pre-change ~14.5m (ideally better on warm pip-buildenv)--no-binary :all:unless overridden