feat(ci): unified build-notification action for Flex Slack alerts#340
Open
y3rsh wants to merge 3 commits into
Open
feat(ci): unified build-notification action for Flex Slack alerts#340y3rsh wants to merge 3 commits into
y3rsh wants to merge 3 commits into
Conversation
Replace simple-build-alert and four workflow notify jobs with one TypeScript action and a single always-on notify job. Routing rules decide message shape and webhook destination in code.
Format action/index.ts and ignore generated dist/ in Prettier checks, matching build-refs.
neo-jesse
reviewed
Jul 7, 2026
neo-jesse
left a comment
Contributor
There was a problem hiding this comment.
move-cache-sync fixes artifact upload order inside the job; it does not move Slack earlier. For “Slack right after deploy, before cache,” you’d still need an in-run-build step after upload (or merge move-cache-sync and add that step). -- is this the expected behavior now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Formalizes Flex build Slack notifications into a single TypeScript action (
build-notification), inspired by and intended to supersede:deployedstatus, clearer payload fields)Before: four
notify-*jobs inbuild-ot3-actions.ymland a compositesimple-build-alertaction with workflow-level conditionals and duplicated inputs.After: one
notify-buildjob (if: always()) that passes all context; the action decides whether to send, message shape (deployed/failure/cancelled), and webhook destination (webhook_urlvswebhook_url_tagged).Follows the same pattern as
build-refs: Node 24 action, unit tests, lint/format CI, and a check that committeddist/index.jsis up to date.Changelog
.github/actions/build-notificationwith tested routing rules and bundleddist/index.js.github/workflows/test-build-notification.ymlCI for the actionbuild-ot3-actions.ymlwith onenotify-buildjob.github/actions/simple-build-alert@actions/coreto v3.x (fixes transitiveundiciaudit findings)Review requests
tag,headline,status, artifact URLs)SLACK_WEBHOOK_URLvsSLACK_WEBHOOK_URL_TAGGED) matches current channel expectationsRisk assessment
Attention level: medium
Trade-offs: notification timing moves to end of workflow (single job) rather than inline after S3 upload; cache sync order unchanged from main.
Blast radius: Flex build Slack notifications only; no BitBake/build logic changes.
Mitigation: 13 unit tests for routing rules; CI verifies dist bundle;
continue-on-error: trueon notify step preserves build job outcome.