Skip to content

chore: avoid double parsing tx_summary in offline execution #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VolodymyrBg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: avoid double parsing tx_summary in offline execution #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions crates/miden-multisig-client/src/client/offline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,12 +334,9 @@ impl MultisigClient {
});
}

// Parse the proposal
// Parse the proposal (includes parsed tx_summary)
let proposal = exported.to_proposal()?;
let tx_summary = TransactionSummary::from_json(&exported.tx_summary).map_err(|e| {
MultisigError::InvalidConfig(format!("failed to parse tx_summary: {}", e))
})?;
let tx_summary_commitment = tx_summary.to_commitment();
let tx_summary_commitment = proposal.tx_summary.to_commitment();

// Convert exported signatures to SignatureInput format
let signature_inputs: Vec<SignatureInput> = exported
Expand Down Expand Up @@ -369,7 +366,12 @@ impl MultisigClient {
if !is_switch_psm {
// Get PSM ack signature and add to advice
let psm_advice = self
.get_psm_ack_signature(&account, proposal.nonce, &tx_summary, tx_summary_commitment)
.get_psm_ack_signature(
&account,
proposal.nonce,
&proposal.tx_summary,
tx_summary_commitment,
)
.await?;
signature_advice.push(psm_advice);
}
Expand Down