Chore/align webgal engine manifest v3#927
Open
A-kirami wants to merge 1 commit intoOpenWebGAL:devfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the webgal-engine.json metadata by adding schemaVersion and id fields, updating the maintainer information, and removing several fields such as readme, keywords, and support flags. A review comment suggests modifying the id field to remove a hyphen, ensuring consistency with the organization's branding and existing URLs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
#762 的 RFC 已更新到 v3 版本,官方 manifest 需要同步到这版规范,避免参考实现与规范定义继续漂移。
这次同步主要解决了几个具体问题:
schemaVersion和idname仍然是旧的机器标识风格,而不是正式显示名称author,不符合当前修改后的maintainer语义本次变更
同步更新官方
packages/webgal/public/webgal-engine.json:schemaVersion: "1.0.0"id: "open-webgal.webgal"name调整为显示名称WebGALauthor调整为maintainername: "OpenWebGAL"email: "contact@openwebgal.com"readmereadmeskeywordslive2dSupportspineSupport说明
readme和readmeskeywords不应填写冗余内容,故一并移除live2dSupport/spineSupport为可选字段,缺失按false处理,因此官方 manifest 不再显式填写false