spec: session-1.md — register user-preference fields; one-purpose-per-field language taxonomy#122
Draft
JarbasAl wants to merge 1 commit into
Draft
spec: session-1.md — register user-preference fields; one-purpose-per-field language taxonomy#122JarbasAl wants to merge 1 commit into
JarbasAl wants to merge 1 commit into
Conversation
…e taxonomy, transient-state disclaimer Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refines OVOS-SESSION-1 to Version 2.
location(object),system_unit,time_format,date_format(strings) — the session origin's presentation preferences, defaulting per §2.1, wire-weight rule §3.4 applies. Same section deliberately declines to registeris_speaking/is_recording: instant device state snapshotted into a propagating session is stale on read; implementations MUST NOT rely on it — OVOS-AUDIO-1 lifecycle signals are authoritative.lang,secondary_langs,output_lang) vs per-utterance observation signals (stt_lang,request_lang,detected_lang); disagreement between the two groups is signal, not error. All six kept — each records a distinct fact no other field carries. Stale "all four" count fixed.session_id; remote"default"SHOULD be gated behind an elevated-privilege grant in layer-2 systems.request_langcites its observable sourceovos.listener.wakeword(AUDIO-IN-1 §6.5).Note: the §3.2.5 citation depends on the AUDIO-IN-1 §6.5
ovos.listener.wakewordsignal landing in its companion PR.🤖 Generated with Claude Code