Skip to content

spec: session-1.md — register user-preference fields; one-purpose-per-field language taxonomy#122

Draft
JarbasAl wants to merge 1 commit into
devfrom
spec/session-1
Draft

spec: session-1.md — register user-preference fields; one-purpose-per-field language taxonomy#122
JarbasAl wants to merge 1 commit into
devfrom
spec/session-1

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Jul 4, 2026

Copy link
Copy Markdown
Member

Refines OVOS-SESSION-1 to Version 2.

  • §3.5 (new): registers location (object), system_unit, time_format, date_format (strings) — the session origin's presentation preferences, defaulting per §2.1, wire-weight rule §3.4 applies. Same section deliberately declines to register is_speaking / is_recording: instant device state snapshotted into a propagating session is stale on read; implementations MUST NOT rely on it — OVOS-AUDIO-1 lifecycle signals are authoritative.
  • §3.2: the six language fields get a one-purpose-per-field summary table, split into stable preference signals (lang, secondary_langs, output_lang) vs per-utterance observation signals (stt_lang, request_lang, detected_lang); disagreement between the two groups is signal, not error. All six kept — each records a distinct fact no other field carries. Stale "all four" count fixed.
  • §3.1: remote participants SHOULD use a distinct session_id; remote "default" SHOULD be gated behind an elevated-privilege grant in layer-2 systems.
  • §3.2.5: wake-word-derived request_lang cites its observable source ovos.listener.wakeword (AUDIO-IN-1 §6.5).
  • §3.4: notes the SESSION-2 §3.2 thin-session allowance.
  • §4.1: materialization citation corrected to MSG-1 §5.1–§5.2; phantom quotation dropped.
  • CHANGELOG entry + Version bump to 2.

Note: the §3.2.5 citation depends on the AUDIO-IN-1 §6.5 ovos.listener.wakeword signal landing in its companion PR.

🤖 Generated with Claude Code

…e taxonomy, transient-state disclaimer

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d3c3e844-c47b-469f-849d-01b0a67509d8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch spec/session-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant