spec: persona.md — persona commands as ordinary intents; total query replies#115
Draft
JarbasAl wants to merge 1 commit into
Draft
spec: persona.md — persona commands as ordinary intents; total query replies#115JarbasAl wants to merge 1 commit into
JarbasAl wants to merge 1 commit into
Conversation
Embedded persona commands (summon/release/ask/list/check) are ordinary intents expressed as locale resources and matched by the standard intent machinery — the plugin is distinguished by its catch-all, not bespoke command matching. The out-of-band ovos.persona.query interface always replies on ovos.persona.answer, with mutually exclusive response/error fields instead of an untyped None. Dismissal mechanics are stated per session class (default: explicit clear; named: client removes the field). persona_id character rules relax to a RECOMMENDED convention; SESSION-1 registry pointers corrected to §2.2. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refines OVOS-PERSONA-1 for internal consistency with the intent and session specs.
Changes
/localetree and matched with the standard intent machinery (OVOS-INTENT-2). No bespoke persona-command matching layer: the plugin is distinguished by its route-2 active-persona catch-all, not by how it recognises its own commands. This keeps PERSONA-1 consistent with the intent specs' single design for command recognition.persona_idthe plugin MUST still reply onovos.persona.answer(echopersona_id/utterance, seterror, omitresponse) instead of returning an untypedNone— a bus request-response contract cannot carry a language-levelNone.response/errorare mutually exclusive fields in the payload table.persona_id(equivalent to absent, §3) viaovos.session.sync, a release intent, or a committedMatch.updated_sessionwithout the field. Named session: the client copy is authoritative; the client dismisses by removing the field.persona_idconstraint relaxed to a RECOMMENDED ASCII letters/digits/_/-convention (naming convention = tuning, not interop).🤖 Generated with Claude Code