spec: ocp-1.md — payload tables, absolute-ms seek, one time convention#111
Draft
JarbasAl wants to merge 1 commit into
Draft
spec: ocp-1.md — payload tables, absolute-ms seek, one time convention#111JarbasAl wants to merge 1 commit into
JarbasAl wants to merge 1 commit into
Conversation
Add the play-request payload (§4.2.1), an absolute-millisecond seek contract (§4.2.2) so concurrent seekers cannot compound relative offsets, first-class search.start/.end bracketing, the shared state-report payload with numeric axis codes (§3.1, §4.4), and the media entry object (§4.5). Durations and positions count uniformly in milliseconds with -1 = unknown/live, matching the GUI-1 player templates. Version bumps to 2 (absolute-ms seek and ms durations are not compatible with the pre-spec conventions). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refines OVOS-OCP-1 with internally consistent payload contracts.
Changes
ovos.common_play.playpayload —media(media entry, required),playlist(defaults to[media]),disambiguation(defaults to the playlist),repeat.positionis an absolute millisecond offset; relative "skip forward N" is resolved by the requester from the §4.4 state reports. One addressing mode keeps concurrent seekers from compounding each other's offsets.search.start/search.endare first-class bracketing Messages with MUST emission points.PlayerStatecodes assigned (0/1/2); shared state-report payload shape; track-state axis described (disambiguation / queued / playing, qualified by backend kind; playing impliesPlayerState.PLAYING, pausing never a track-state value).lengthis milliseconds with-1= unknown/live, aligning the whole media surface (seek, media entry, GUI-1 player templates) on one time convention.Follow-ups
MediaState, track state,PlaybackType,media_type) still need a normative registry; onlyPlayerStateis coded here.🤖 Generated with Claude Code