spec: audio-out.md — container-authoritative audio format; mime/sample_rate optional#106
Draft
JarbasAl wants to merge 1 commit into
Draft
spec: audio-out.md — container-authoritative audio format; mime/sample_rate optional#106JarbasAl wants to merge 1 commit into
JarbasAl wants to merge 1 commit into
Conversation
…ample_rate The audio format is intrinsic to the payload's container: WAV/MP3/OGG/ FLAC self-describe via their leading bytes, so a mandatory mime field would be a second, contradictable declaration. mime and sample_rate are OPTIONAL advisory hints; both are REQUIRED only for headerless raw streams (raw PCM). Applied uniformly to ovos.audio.queue, play_sound and speech (new §4.0). is_speaking now answers via the MSG-1 response derivation. TRANSFORM-1 referenced by its actual title. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refines OVOS-AUDIO-1 to a single, pure audio-format rule.
Changes
mimeis therefore OPTIONAL and advisory (a hint a consumer MAY use to skip container detection; the container is authoritative on disagreement).sample_rateis OPTIONAL. Both become REQUIRED only when the payload is a headerless raw stream (raw PCM) with no container. Applied uniformly toovos.audio.queue(§4.1),ovos.audio.play_sound(§4.2), andovos.audio.speech(§4.3).responsederivation (ovos.audio.is_speaking.response), closing an unspecified reply leg.Version stays 2: these are editorial/additive refinements within the existing compatibility class (VERSIONING.md).
🤖 Generated with Claude Code