Skip to content

less agressive caching for js files without "?mod=" #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veselcraft merged 4 commits into from
Aug 30, 2026
Merged

less agressive caching for js files without "?mod=" #37

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a6658f
Update Router.php
crythoughts Aug 23, 2026
8e998d3
Update Router.php
crythoughts Aug 23, 2026
5708d7e
Update Router.php
crythoughts Aug 23, 2026
ba8984f
Update Router.php
crythoughts Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions chandler/MVC/Routing/Router.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ private function delegateRoute(Route $route, array $matches): string
return $this->delegateController($route->namespace, $route->presenter, $route->action, $parameters);
}

public function delegateStatic(string $namespace, string $path): string
public function delegateStatic(string $namespace, string $path, ?array $queryParams): string
{
$static = $static = $this->statics[$namespace];
if (!isset($static)) {
Expand All @@ -225,9 +225,17 @@ public function delegateStatic(string $namespace, string $path): string
}
}

// This is needed for ES6 modules. They do not use "?mod=" parameter and may be irrelevant

$isLighterCaching = system_extension_mime_type($file) === "text/javascript" && $queryParams["mod"] == null;
if ($isLighterCaching) {
header("Cache-Control: no-cache, max-age=3600");
} else {
header("Cache-Control: public, must-understand, immutable, max-age=628000000");
}

header("Content-Type: " . system_extension_mime_type($file) ?? "text/plain; charset=unknown-8bit");
header("Content-Size: " . filesize($file));
header("Cache-Control: public, must-understand, immutable, max-age=628000000");
header("ETag: $hash");

readfile($file);
Expand Down Expand Up @@ -334,7 +342,15 @@ public function execute(string $url, ?string $parentModule = null): ?string

if (preg_match("%^\/assets\/packages\/static\/([A-z_\\-]++)\/(.++)$%", $this->url, $matches)) {
[$j, $namespace, $file] = $matches;
return $this->delegateStatic($namespace, $file);
$queryString = parse_url(preg_replace("%/+%", "/", $url), PHP_URL_QUERY);

try {
parse_str($queryString, $queryParams);
} catch (\Throwable $e) {
$queryParams = [];
}

return $this->delegateStatic($namespace, $file, $queryParams);
}

$match = $this->getMatchingRoute($this->url);
Expand Down
Loading