Repository navigation
fix(chat): preserve reasoning_details that arrive after the reasoning block closes #608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LukasParke
wants to merge
3
commits into
main
Choose a base branch
from
claude/late-reasoning-details
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+569
−84
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
223c3ee
fix(chat): preserve reasoning_details that arrive after the reasoning…
LukasParke c8e24f8
fix(chat): on equal length, prefer a later carrier only when it conti…
LukasParke 2c34fcf
test: move the carrier selection describe next to the reasoning dedup…
LukasParke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@openrouter/ai-sdk-provider': patch | ||
| --- | ||
|
|
||
| Preserve `reasoning_details` that arrive after the reasoning block has closed (e.g. a late `reasoning.encrypted` blob or signature-only delta after text started) across turns. `doStream` now attaches a snapshot of the details to each carrier part and, when details arrived after the last carrier, emits an empty reasoning part carrying the complete array. The message converter replays the most complete carrier, so every detail is sent back exactly once, including when the stream is serialized over the wire (e.g. the UI message stream). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Earlier reasoning blocks disappear on replay
When
doGeneratereturns multiple reasoning parts without tool calls,findMostCompleteReasoningDetailskeeps only the last part on a tie. Earlier signed thinking blocks disappear from the next request.Learn more
Non-streaming responses from doGenerate give each reasoning part a one-element
reasoning_detailsarray, unlike streaming's cumulative snapshots. The converter now replaces an earlier equally sized array with the last one. Thus it discards reasoning that the earlier implementation retained, and cannot reconstruct the whole response by choosing one carrier.Example: A response has two signed Anthropic thinking details,
FirstandSecond, and no tool call.doGeneratereturns[First]and[Second]on separate reasoning parts. The next request now sends only[Second], not both blocks.Recommended fix: Preserve the distinction between cumulative streamed carriers and per-detail non-streamed parts. Aggregate distinct non-streamed reasoning parts in order, while selecting a single cumulative snapshot for streamed parts and tool calls; test both paths with multiple signed blocks and mixed summary/encrypted details.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Fixed in the latest commit: on an equal-length tie, a later carrier now wins only if it continues the current one entry by entry (an in-place merge such as a late signature). So separate per-detail
doGenerateparts like[First],[Second]keep[First], as onmain, and there's a test for it. Combining per-detaildoGenerateparts is in scope for #600: its first reasoning part carries the full array, and 'most entries wins' selects it.