Repository navigation
Fix the static library dependency of testoauth - #1787
Merged
michaelrsweet merged 1 commit intoOct 28, 2026
Merged
michaelrsweet merged 1 commit into
michaelrsweet merged 1 commit into
Conversation
michaelrsweet
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testoauthdepends on$(LIBCUPS_STATIC), but the configured variable isLIBCUPSSTATIC. The missing dependency lets a parallel build start linking the test whilelibcups.ais still being archived, producing undefined references. It also means building the target alone does not build its required library.Use the same
$(LIBCUPSSTATIC)prerequisite as the neighboring test targets.Validation in Ubuntu under WSL with GCC:
./configure --enable-unit-tests --prefix=<workspace>/cups-installfollowed bymake -j4reproduced the undefined-reference failure intestoauthbefore the change.make -C cups -B -n testoauthpreviously omitted archivinglibcups.a; after the fix it includes the library build before linking.make clean, the completemake -j4build succeeds with the fix.cups/testoauth --helpexecutable runs;git diff --checkpasses.Existing
_FORTIFY_SOURCEredefinition and recursive-make jobserver warnings remain. Nothing was installed into the system printing service.