Repository navigation
Fix destination enumeration without DNS-SD - #1740
Merged
Merged
Conversation
Add the local destination fields used by cups_enum_dests to the non-DNS-SD callback data structure. Fixes OpenPrinting#1739 Signed-off-by: Rui Chen <rui@chenrui.dev>
7 tasks done
fanboimsft
added a commit
to sauzerOS/sauzeros
that referenced
this pull request
Oct 6, 2026
2.4.20 uses data.num_local/local_dests in cupsEnumDests() without the HAVE_DNSSD guard, but only the DNS-SD struct has them, so the cross build (--disable-avahi) fails to compile dest.c. Apply the upstream fix from OpenPrinting/cups#1740 (issue #1739). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Thx! We don't have test for this, because 2.5 has hard dependency on dnssd provider, but IMO we can add one test for 2.4.x. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cups_enum_destsaccessesnum_localandlocal_destsin the non-DNS-SD path, but_cups_getdata_tdoes not declare them. Add the fields already present in the DNS-SD data structure so CUPS 2.4.20 builds without DNS-SD support.Fixes #1739.
AI-assisted with OpenAI Codex (GPT-6). The equivalent patch passed source builds and Homebrew's printer test on Ubuntu 24.04 x86_64 and macOS 26 arm64; validation was performed by AI. No human runtime verification was performed.