fix: reflect back the changes after completing MCQs without the need … - #25
Closed
choeying-10 wants to merge 1 commit into
Closed
fix: reflect back the changes after completing MCQs without the need …#25choeying-10 wants to merge 1 commit into
choeying-10 wants to merge 1 commit into
Conversation
…to refresh the page or getting out of course and back in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
completions.jsso MCQproblem_check(not onlypublish_completion) callscompletionSet()and starts a native refresh.flow.last()inCourseInteractor.getCourseStructurewhenisNeedRefreshis true so refresh waits for the network emission instead of returning cached structure via.first().CourseContainerViewModel.updateData()with a trailing refresh so rapid back-to-back MCQs are not coalesced onto one stale in-flight fetch.Why
MCQs never hit
publish_completion, so the app often never refreshed after submit. When a refresh did run, the cache-first structure flow plus.first()returned old data (including stalecourse_progress). Overlapping refreshes could also drop a completion until a later attempt.