Harden legacy converter checkpoint loading#2036
Open
igorsantosgrueiro wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
weights_only=Trueby default.--unsafe_deserializationas an explicit opt-in for trusted legacy checkpoints that still require Python pickle globals.This preserves a compatibility path for existing trusted local checkpoints while avoiding unsafe pickle deserialization by default.
Fixes #2034.
Rationale
Some legacy OpenNMT-py/Fairseq checkpoints may include Python objects in addition to tensors and may not load with
weights_only=True. Instead of removing that behavior entirely, this PR makes the unsafe behavior explicit and documented at the converter CLI boundary.Testing