Repository navigation
Refactor/inline i18n - #9
Merged
Merged
Conversation
Two synchronized locales/en.json + locales/ja.json files were error-prone to keep in sync (every string needed a matching, correctly-nested edit in both). t() now takes a Translations object (Record<Locale, string>) directly instead of a dotted key looked up in a runtime-loaded catalog, so each string can live right next to the code that uses it. Drops the i18next/i18next-fs-backend dependencies along with the discovery/backend machinery they required.
…ands buildScopeCommand now takes a ScopeCommandDescriptions object built by each of /settings, /server-settings and /admin, instead of a key-string prefix looked up generically inside scope.ts.
Replaces the "drop a locales/<code>.json file" instructions, which no longer apply now that translations live next to the code that uses them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.