Repository navigation
Chore/library replacements - #10
Merged
Merged
Conversation
mustache replaces a hand-rolled {{var}} interpolation regex in the i18n
helper; quick-lru replaces a hand-rolled bounded FIFO map for the posted-quote
state cache. Split into the next two commits.
…ith Intl.Locale
Replaces the hand-rolled {{var}} regex substitution in t() with
Mustache.render() (escaping disabled, since Discord messages are plain
text, not HTML). normalizeLocale() now pulls the language subtag via the
platform's own Intl.Locale instead of a manual split("-")[0].
Behavior note: a missing interpolation var now renders as empty string
(Mustache's default) rather than leaving the {{var}} placeholder literally
in the output — every call site always supplies its vars, so this never
triggers in practice.
Replaces a hand-rolled bounded Map (delete+re-set to fake FIFO ordering, manual eviction loop) with quick-lru, which also upgrades eviction from FIFO to actual least-recently-used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.